Skip to content

feat(admin): emit AsmStfUpdate log on ASM verifying key update#63

Merged
prajwolrg merged 2 commits intomainfrom
STR-1721-asm-vk-change-log
Apr 16, 2026
Merged

feat(admin): emit AsmStfUpdate log on ASM verifying key update#63
prajwolrg merged 2 commits intomainfrom
STR-1721-asm-vk-change-log

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Apr 7, 2026 •
edited
Loading

Description

Implement AsmStfUpdate log emission when an ASM predicate update activates and add tests to verify it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg changed the title feat: asm vk change log feat(admin): emit AsmStfUpdate log on ASM verifying key update Apr 7, 2026
@prajwolrg prajwolrg force-pushed the STR-1721-asm-vk-change-log branch from a5f9793 to 9658ae7 Compare April 7, 2026 15:32
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/subprotocols/admin/src/handler.rs 96.29% 1 Missing ⚠️
Files with missing lines Coverage Δ
crates/subprotocols/admin/src/handler.rs 97.24% <96.29%> (+2.49%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026 •
edited
Loading

Commit: 38bc9b5
SP1 Execution Results

program cycles success
ASM STF 118,475,817 yes
Moho Recursive 11,576,264 yes

@prajwolrg prajwolrg marked this pull request as ready for review April 8, 2026 01:47
@prajwolrg prajwolrg self-assigned this Apr 8, 2026
@prajwolrg prajwolrg force-pushed the STR-1721-asm-vk-change-log branch from 9658ae7 to 7b5132a Compare April 16, 2026 15:59
@prajwolrg prajwolrg added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 357e0bb Apr 16, 2026
22 checks passed
@prajwolrg prajwolrg deleted the STR-1721-asm-vk-change-log branch April 17, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irnb irnb irnb approved these changes

@evgenyzdanovich evgenyzdanovich Awaiting requested review from evgenyzdanovich

Assignees

@prajwolrg prajwolrg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prajwolrg @irnb